Skip to content

Make user secrets lazy load.#2998

Merged
mitchdenny merged 3 commits intomainfrom
midenn/user-secrets-lazy
Mar 20, 2024
Merged

Make user secrets lazy load.#2998
mitchdenny merged 3 commits intomainfrom
midenn/user-secrets-lazy

Conversation

@mitchdenny
Copy link
Copy Markdown
Member

@mitchdenny mitchdenny commented Mar 19, 2024

Turns user secret loading into a lazy operation that is awaited in each resource provisioning operation.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 19, 2024
@mitchdenny mitchdenny requested a review from davidfowl March 19, 2024 06:28
@mitchdenny
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I just realized this isn't right. I might have been wrong here 😭. We can't save this as it'll overwrite the file.

@dotnet-policy-service dotnet-policy-service bot added the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 20, 2024
@mitchdenny
Copy link
Copy Markdown
Member Author

Hmm, I just realized this isn't right. I might have been wrong here 😭. We can't save this as it'll overwrite the file.

I don't follow. It seems to work as expected.

@dotnet-policy-service dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Mar 20, 2024
@mitchdenny mitchdenny merged commit 4923bc6 into main Mar 20, 2024
@mitchdenny mitchdenny deleted the midenn/user-secrets-lazy branch March 20, 2024 01:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants