Address peer feedback.

[IEvangelist]

See #2851 (review)

Microsoft Reviewers: Open in CodeFlow

[davidfowl]

I think before we merge this, we should verify what it means to have a non string argument. Doesn't this translate into a command line argument anyways? (strings)

[eerhardt]

I think before we merge this, we should verify what it means to have a non string argument. Doesn't this translate into a command line argument anyways? (strings)

I'd be fine with "true" in the manifest (i.e. only supporting JSON strings).

I'm not sure how the current code works today with "{{bool.TrueString}}".

[IEvangelist]

I think before we merge this, we should verify what it means to have a non string argument. Doesn't this translate into a command line argument anyways? (strings)

I'd be fine with "true" in the manifest (i.e. only supporting JSON strings).

I'm not sure how the current code works today with "{{bool.TrueString}}".

That was the test code, it evaluated as "SOME_BOOL": "True". I'd assume it's probably pretty common for true/false values. Even STJ doesn't have native support for mapping the string representation of bool to a bool property type. This change adds bool support only, otherwise it's functionally the same as it was before.