Use API key auth for OTLP in local development#3031
Merged
Conversation
davidfowl
reviewed
Mar 20, 2024
davidfowl
reviewed
Mar 20, 2024
Member
Author
|
FYI @martinjt I've looked at how your https://github.com/practical-otel/opentelemetry-aspire-collector/ works and I believe it will need some changes but should continue to be possible if API key auth is added to the dashboard's OTLP endpoint. You'll need to:
|
davidfowl
approved these changes
Mar 20, 2024
|
Cool, I can do that, I'm assuming thar will be Preview 5? |
Member
Author
|
Yes, preview 5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR added API key auth to OTLP endpoint. There is the opportunity to secure the local dev environment by using API key auth and having the host co-ordinate the dashboard and user apps.
This PR:
DOTNET_DISABLE_OTLP_API_KEY_AUTH=truesetting to apphost.Microsoft Reviewers: Open in CodeFlow