Skip to content

Split Aspire.Hosting.Azure into sub-packages.#3062

Merged
davidfowl merged 9 commits intomainfrom
mitchdenny/split-hosting-azure
Mar 21, 2024
Merged

Split Aspire.Hosting.Azure into sub-packages.#3062
davidfowl merged 9 commits intomainfrom
mitchdenny/split-hosting-azure

Conversation

@mitchdenny
Copy link
Copy Markdown
Member

@mitchdenny mitchdenny commented Mar 21, 2024 •
edited
Loading

Splitting Aspire.Hosting.Azure into sub-packages (e.g. Aspire.Hosting.Azure.Redis. The package suffix will be dictated by the corresponding package name in the Azure.ResourceManager.* packages. This PR is just the structural change.

  • Redis
  • AppConfig
  • Storage?
  • Cosmos
  • AppInsights
  • LogAnalytics
  • OpenAI
  • Postgres
  • Search
  • ServiceBus
  • SignalR
  • SqlServer

Some resources will stay in the main Aspire.Hosting.Azure package. At this point its the provisioning machinery, Bicep resource, construct resoure, KeyVault.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 21, 2024
@radical
Copy link
Copy Markdown
Member

radical commented Mar 21, 2024

It would be useful to add tests that exercise these nugets in Aspire.EndToEnd.Tests - since these tests use the nugets produced in artifacts to build, and run a test project.

@davidfowl
Copy link
Copy Markdown
Contributor

davidfowl commented Mar 21, 2024

It would be useful to add tests that exercise these nugets in Aspire.EndToEnd.Tests - since these tests use the nugets produced in artifacts to build, and run a test project.

We don't have a reasonable way to test against azure resources yet (AFAIK)

@radical
Copy link
Copy Markdown
Member

radical commented Mar 21, 2024

It would be useful to add tests that exercise these nugets in Aspire.EndToEnd.Tests - since these tests use the nugets produced in artifacts to build, and run a test project.

We don't have a reasonable way to test against azure resources yet (AFAIK)

Ah, yes, Azure!

@mitchdenny mitchdenny force-pushed the mitchdenny/split-hosting-azure branch from c7206d4 to 0c22073 Compare March 21, 2024 09:49
@mitchdenny mitchdenny mentioned this pull request Mar 21, 2024
Closed
@mitchdenny mitchdenny marked this pull request as ready for review March 21, 2024 10:39
@mitchdenny
Copy link
Copy Markdown
Member Author

mitchdenny commented Mar 21, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 21, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny mitchdenny mentioned this pull request Mar 21, 2024
Merged
15 tasks
@davidfowl davidfowl mentioned this pull request Mar 21, 2024
Merged
davidfowl
davidfowl reviewed Mar 21, 2024
View reviewed changes
Aspire.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aspire.Hosting.Azure.OperationalInsights", "src\Aspire.Hosting.Azure.OperationalInsights\Aspire.Hosting.Azure.OperationalInsights.csproj", "{8CF39705-FCA7-42F5-B3E3-1FBD9100BAFF}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aspire.Hosting.Azure.PostgreSql", "src\Aspire.Hosting.Azure.PostgreSql\Aspire.Hosting.Azure.PostgreSql.csproj", "{B6F2387B-2AB0-41F4-A609-9EA13E408145}"
Copy link
Copy Markdown
Contributor

@davidfowl davidfowl Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have Aspire.Hosting.PostgreSQL (casing)

Copy link
Copy Markdown
Member Author

@mitchdenny mitchdenny Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tg-msft FYI

davidfowl
davidfowl reviewed Mar 21, 2024
View reviewed changes
Aspire.sln
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aspire.Hosting.Azure.SignalR", "src\Aspire.Hosting.Azure.SignalR\Aspire.Hosting.Azure.SignalR.csproj", "{CB7CAE39-F041-4B20-A0C4-D6F44920A647}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Aspire.Hosting.Azure.Sql", "src\Aspire.Hosting.Azure.Sql\Aspire.Hosting.Azure.Sql.csproj", "{9FF853BD-FA56-4DA5-A50A-9867F2FAB1F0}"
Copy link
Copy Markdown
Contributor

@davidfowl davidfowl Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have Aspire.Hosting.SqlServer. Sql feels a little generic.

Copy link
Copy Markdown
Member Author

@mitchdenny mitchdenny Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tg-msft FYI

Copy link
Copy Markdown
Contributor

@JoshLove-msft JoshLove-msft Mar 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RM library uses Sql as well - Azure.ResourceManager.Sql.

@davidfowl davidfowl merged commit 46b39c2 into main Mar 21, 2024
@davidfowl davidfowl deleted the mitchdenny/split-hosting-azure branch March 21, 2024 14:07
@davidfowl davidfowl mentioned this pull request Mar 22, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidfowl davidfowl davidfowl approved these changes

+1 more reviewer

@JoshLove-msft JoshLove-msft JoshLove-msft left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mitchdenny @radical @davidfowl @JoshLove-msft