Merged
Conversation
ghost
added
the
area-app-model
davidfowl
approved these changes
Mar 23, 2024
davidfowl
reviewed
Mar 23, 2024
davidfowl
reviewed
Mar 23, 2024
Co-authored-by: David Fowler <davidfowl@gmail.com>
eerhardt
added a commit
to eerhardt/aspire
that referenced
this pull request
Mar 25, 2024
Follow up to microsoft#3120
Merged
eerhardt
reviewed
Mar 25, 2024
| <PropertyGroup> | ||
| <TargetFramework>$(NetCurrent)</TargetFramework> | ||
| <IsPackable>true</IsPackable> | ||
| <PackageTags>aspire hosting azure</PackageTags> |
Member
There was a problem hiding this comment.
Why doesn't this have keyvault in it?
| <TargetFramework>$(NetCurrent)</TargetFramework> | ||
| <IsPackable>true</IsPackable> | ||
| <PackageTags>aspire hosting azure</PackageTags> | ||
| <Description>Azure resource types for .NET Aspire.</Description> |
Member
There was a problem hiding this comment.
This should say "Azure KeyVault".
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Mar 25, 2024
Follow up to microsoft#3120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the hosting extensions for Azure Key Vault into their own assembly. They don't need to be in the core. I've also added a README as a bit of a format check.
Microsoft Reviewers: Open in CodeFlow