Add OTEL env var to not redact HttpClient query string values#3797
Merged
Add OTEL env var to not redact HttpClient query string values#3797
Conversation
davidfowl
reviewed
Apr 18, 2024
JamesNK
force-pushed
the
jamesnk/httpclient-redaction
branch
from
22dd572 to
f1fc7db
Compare
davidfowl
approved these changes
Apr 19, 2024
JamesNK
commented
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React to feedback to OTEL changes after PR was merged: https://github.com/dotnet/aspire/pull/3676/files#r1566223568
Don't redact outgoing HTTP request query string values in local development.
Before:
After:
This PR:
OTEL_DOTNET_EXPERIMENTAL_HTTPCLIENT_DISABLE_URL_QUERY_REDACTIONenv varMicrosoft Reviewers: Open in CodeFlow