Service Discovery: make scheme selection more intuitive in un-specified case, add more tests#3837
Merged
ReubenBond merged 1 commit intomainfrom Apr 19, 2024
Conversation
…ection more intuitive in un-specified case
BrennanConroy
approved these changes
Apr 19, 2024
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8759708724 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make scheme selection more intuitive
ServiceDiscoveryOptions.AllowAllSchemesis TRUE and the service name INCLUDES schemes (eghttps://basket), we filter out results which do not have a matching scheme, applying the preference. i.e,https+httpmeans pick onlyhttpsendpoints if anyhttpsendpoints are present,httponly if nohttpsendpoints are present.ServiceDiscoveryOptions.AllowAllSchemesis TRUE and the service name DOES NOT INCLUDE schemes (eg,basket), then we should allow all endpoints.ServiceDiscoveryOptions.AllowAllSchemesis FALSE, the service name DOES NOT INCLUDE schemes, andServiceDiscoveryOptions.AllowedSchemescontains some value (eg,["https"]), then we should filter to include only endpoints matching thoseAllowedSchemesvalues.In pseudo code, the logic is:
Always check "default" config section first when no endpoint name is specified
"default"section, then the sections corresponding to schemes. The current behavior is:https+http-> check"https"then"http"cfg sections)"default"section.The change is to always check the default section first if no endpoint name is specified.
Microsoft Reviewers: Open in CodeFlow