Improve filtering of log messages when there are duplicate attributes#3881
Merged
Improve filtering of log messages when there are duplicate attributes#3881
Conversation
Member
Author
|
Review please 🙏 |
drewnoakes
approved these changes
May 10, 2024
| _parameters = | ||
| [ | ||
| .. knownFields, | ||
| new SelectViewModel<string> { Id = null, Name = "-" }, |
Member
There was a problem hiding this comment.
Is there not a better way to create a separator with this control?
Member
Author
There was a problem hiding this comment.
Not that I know of - https://www.fluentui-blazor.net/Select
JamesNK
force-pushed
the
jamesnk/message-filtering
branch
from
6ae4554 to
ca0275d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3614
Log entries have built-in fields. e.g. the message body, level, category, etc. Log entries also have custom fields. This is from structured data about a message.
It's possible for these to conflict. Structured data could be called
MessageorCategory. If the user then asks to filter with theMessagevalue, which is used? A conflict is created and it's only possible to filter the built-in fields.This PRs fix is to give custom built-in fields an internal name, e.g.
log.message. That is much less likely to conflict with real structured data.Also, I added a divider (disabled select item with text
-) between built-in fields and structured data fields to make the UI experience a bit better:Microsoft Reviewers: Open in CodeFlow