Add Encrypt=True to test connection strings#3903
Merged
Conversation
ghost
added
the
area-integrations
eerhardt
approved these changes
Apr 24, 2024
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Lgtm
is there anyway to catch these kinds of things during PR validation?
Member
Author
Not really. CodeQL runs are intentionally asynchronous since they take so long to execute. Otherwise people would be waiting hours - maybe days - for CI to go green. And then you have an angry mob at your doorstep. :) |
Member
Author
|
Following up - confirmed that the raw tool output from the latest runs shows this issue as resolved. It'll take a few days to percolate through the reporting system, but we should consider this fully resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should silence some CodeQL alerts we're receiving in our backend systems.
Yes, it's test code. There's a weird policy governing when test code is / is not required to be in scope during CodeQL runs. Making these very targeted changes to the test code seemed like the path of least resistance.
Microsoft Reviewers: Open in CodeFlow