Fix safari column header heights#4013
Merged
adamint merged 1 commit intomicrosoft:mainfrom Apr 29, 2024
Merged
Conversation
adamint
requested review from
JamesNK,
danmoseley,
kvenkatrajan,
tlmii and
vnbaaij
ghost
added
the
area-codeflow
kvenkatrajan
approved these changes
Apr 29, 2024
vnbaaij
approved these changes
Apr 29, 2024
Member
|
Testing this here locally on windows with a couple browsers and it seems fine. I can't validate the Safari side. It'd be nice to see if we can find an actual bug logged on Safari about this (both from a tracking perspective, so we can undo the hack if it ever gets fixed, and from the perspective of making sure we fully understand why Safari is behaving the way it is). But this seems to fix it for us right now. Thanks @adamint for digging into this! |
tlmii
approved these changes
Apr 29, 2024
|
@danmoseley / @joperezr are you ok with backporting this to to 8.0 for GA? |
Member
Author
|
@tlmii I can file a follow-up issue to make a minimal repro of this? |
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8883981932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3958
Taken from the comment I made in the css:
fluent-data-grid-cells have a height of 100%, which should correspond to the height of their parent fluent-data-grid-row.
On Safari only, this is not the case; height actually computes to the grid height (incorrectly). We can force column headers to take the height of their parent by inheriting the height of their row.
Before, Safari
Before, Chrome/Edge
After, Safari
After, Chrome/Edge
Microsoft Reviewers: Open in CodeFlow