Skip to content

"All" should use the same word#4073

Merged
tlmii merged 29 commits intomicrosoft:mainfrom
Varorbc:all
Jun 12, 2024
Merged

"All" should use the same word#4073
tlmii merged 29 commits intomicrosoft:mainfrom
Varorbc:all

Conversation

@Varorbc
Copy link
Copy Markdown
Contributor

@Varorbc Varorbc commented May 3, 2024

fix #3940

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-dashboard label May 3, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 3, 2024
@kvenkatrajan kvenkatrajan requested review from adamint and tlmii May 7, 2024 21:52
@kvenkatrajan
Copy link
Copy Markdown

@Varorbc - Thanks! LGTM

@tlmii / @adamint please review

Copy link
Copy Markdown

@kvenkatrajan kvenkatrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tlmii
Copy link
Copy Markdown
Member

tlmii commented Jun 11, 2024

@Varorbc I know this PR has been sitting here for a bit, but do you remember why all the .xlf files were edited in separate commits? Usually they're all changed by the tooling at once when you do a build after editing the resx file. In general, the change seems like a good idea I'm just curious about the process since we don't normally spend a ton of time looking at the generated files.

@Varorbc
Copy link
Copy Markdown
Contributor Author

Varorbc commented Jun 11, 2024

@tlmii I modified them one by one.

@tlmii tlmii merged commit 19ec1d9 into microsoft:main Jun 12, 2024
@Varorbc Varorbc deleted the all branch June 12, 2024 23:10
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-dashboard community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"All" should use the same word

3 participants