Skip to content

Changing the title of the Aspire starter project#4207

Merged
danmoseley merged 3 commits intomainfrom
sayedha/fixtempaltename4178
May 18, 2024
Merged

Changing the title of the Aspire starter project#4207
danmoseley merged 3 commits intomainfrom
sayedha/fixtempaltename4178

Conversation

@sayedihashimi
Copy link
Copy Markdown
Member

@sayedihashimi sayedihashimi commented May 16, 2024

Changing the title of the Aspire starter project template from '.NET Aspire Starter Application' to '.NET Aspire Starter App'.
This is more consistent with Visual Studio.
Related issue #4178.

Let me know if this PR should go to a different branch.

Microsoft Reviewers: Open in CodeFlow

tempalte from '.NET Aspire Starter Application' to
'.NET Aspire Starter App'.
This is more consistent with Visual Studio.
Related issue #4178.
@ghost ghost added the area-templates label May 16, 2024
@DamianEdwards
Copy link
Copy Markdown
Member

DamianEdwards commented May 17, 2024

@sayedihashimi can you update the empty template too? https://github.com/dotnet/aspire/blob/21a58881c899b7c4aee75aa24508e2adefeabd2f/src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/template.json#L13

Maybe we should probably rename that one to ".NET Aspire Empty App" while we're here

@sayedihashimi
Copy link
Copy Markdown
Member Author

@sayedihashimi can you update the empty template too?

https://github.com/dotnet/aspire/blob/21a58881c899b7c4aee75aa24508e2adefeabd2f/src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/template.json#L13

Maybe we should probably rename that one to ".NET Aspire Empty App" while we're here

Sorry I missed that one when I made the initial PR, it has been updated now.

Comment thread src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/template.json Outdated
Copy link
Copy Markdown
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danmoseley danmoseley merged commit 90cd4b5 into main May 18, 2024
@danmoseley danmoseley deleted the sayedha/fixtempaltename4178 branch May 18, 2024 03:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants