[tests] Fix installing workload for tests on Windows in the internal pipeline#4259
Merged
radical merged 3 commits intomicrosoft:mainfrom May 22, 2024
Merged
[tests] Fix installing workload for tests on Windows in the internal pipeline#4259radical merged 3 commits intomicrosoft:mainfrom
radical merged 3 commits intomicrosoft:mainfrom
Conversation
.. so it gets the correct version suffix for internal builds.
.. to `9.0.0-preview.5.24272.3`. This is to pick up the fix from dotnet/runtime#102533 .
Member
Author
|
Validation build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2458589 |
Member
Author
|
New validation builds - https://dev.azure.com/dnceng/internal/_build/results?buildId=2458641&view=results |
eerhardt
approved these changes
May 22, 2024
Member
Author
Tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation of the sdk+workload for testing failed on Windows in the internal pipeline with:
This is because on the internal pipeline the version is like
8.1.0-preview.1.24270.2instead of8.1.0-ci, so the generated nugets use that version. But the workload install step did not pass theOfficialBuildIdwhich caused the build to get the8.1.0-civersion instead, causing the failure.Once that is fixed an issue (dotnet/runtime#102533) was hit in the workload task for which the nuget is being updated here.
Fixes #4246 .
Microsoft Reviewers: Open in CodeFlow