Skip to content

[tests] Fix installing workload for tests on Windows in the internal pipeline#4259

Merged
radical merged 3 commits intomicrosoft:mainfrom
radical:fix-internal-build
May 22, 2024
Merged

[tests] Fix installing workload for tests on Windows in the internal pipeline#4259
radical merged 3 commits intomicrosoft:mainfrom
radical:fix-internal-build

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented May 22, 2024

The installation of the sdk+workload for testing failed on Windows in the internal pipeline with:

##[error].packages\microsoft.net.runtime.workloadtesting.internal\9.0.0-preview.4.24208.7\Sdk\WorkloadTesting.Core.targets(201,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Restoring packages failed with exit code: 1. Output:
  Determining projects to restore...
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102: Unable to find package Microsoft.NET.Sdk.Aspire.Manifest-8.0.100 with version (= 8.1.0-ci)
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102:   - Found 786 version(s) in dotnet8 [ Nearest version: 8.1.0-preview.1.24178.6 ]
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102:   - Found 8 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.7.24251.11 ]
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102:   - Found 1 version(s) in nuget-local [ Nearest version: 8.1.0-preview.1.24270.2 ]
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102:   - Found 0 version(s) in dotnet9-transport
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102:   - Found 0 version(s) in dotnet-eng
D:\a\_work\1\s\artifacts\obj\workload-q3zh33t1.fms\surfuxtl.vly\restore\Restore.csproj : error NU1102:   - Versions from dotnet-libraries were not considered

This is because on the internal pipeline the version is like 8.1.0-preview.1.24270.2 instead of 8.1.0-ci, so the generated nugets use that version. But the workload install step did not pass the OfficialBuildId which caused the build to get the 8.1.0-ci version instead, causing the failure.

Once that is fixed an issue (dotnet/runtime#102533) was hit in the workload task for which the nuget is being updated here.
Fixes #4246 .

Microsoft Reviewers: Open in CodeFlow

radical added 2 commits May 22, 2024 15:55
.. so it gets the correct version suffix for internal builds.
.. to `9.0.0-preview.5.24272.3`. This is to pick up the fix from
dotnet/runtime#102533 .
@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label May 22, 2024
@radical radical added testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels May 22, 2024
@radical
Copy link
Copy Markdown
Member Author

radical commented May 22, 2024

@radical radical marked this pull request as ready for review May 22, 2024 20:48
@radical
Copy link
Copy Markdown
Member Author

radical commented May 22, 2024

@radical
Copy link
Copy Markdown
Member Author

radical commented May 22, 2024

New validation builds - dev.azure.com/dnceng/internal/_build/results?buildId=2458641&view=results

Tests passed.

@radical radical merged commit e5c60e7 into microsoft:main May 22, 2024
@radical radical deleted the fix-internal-build branch May 22, 2024 22:13
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2024
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners testing ☑️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal pipeline build broken on Windows

2 participants