Skip to content

Improve error handling in DistributedApplicationFactory#4331

Merged
ReubenBond merged 1 commit intomainfrom
rebond/fix-test-crash-pre-build
May 31, 2024
Merged

Improve error handling in DistributedApplicationFactory#4331
ReubenBond merged 1 commit intomainfrom
rebond/fix-test-crash-pre-build

Conversation

@ReubenBond
Copy link
Copy Markdown
Member

@ReubenBond ReubenBond commented May 29, 2024

Fixes #4330

Please note the public API change to add string[] args to the test app builders.

Microsoft Reviewers: Open in CodeFlow

Copy link
Copy Markdown
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a consumption API point of view!

@ReubenBond
Copy link
Copy Markdown
Member Author

@mitchdenny PTAL

@ReubenBond ReubenBond requested a review from mitchdenny May 30, 2024 15:39
@ReubenBond ReubenBond merged commit 092ed1f into main May 31, 2024
@ReubenBond ReubenBond deleted the rebond/fix-test-crash-pre-build branch May 31, 2024 13:50
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests hang when using xUnit and DistributedApplicationTestingBuilder if an exception is thrown in the AppHost project before the host is built

3 participants