style: change finished ressource icon to success#4365
Merged
drewnoakes merged 1 commit intomicrosoft:mainfrom Jun 4, 2024
Merged
style: change finished ressource icon to success#4365drewnoakes merged 1 commit intomicrosoft:mainfrom
drewnoakes merged 1 commit intomicrosoft:mainfrom
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
adamint
approved these changes
Jun 4, 2024
Contributor
|
I think this broke "Failed to start" with a null or 0 exit code: 
|
Member
|
Yes @davidfowl we needed to handle specifically just the “Finished” state. This is my responsibility for missing the issue. I will submit a change later today |
Contributor
|
Filed an issue here #4498 |
Contributor
Author
|
@adamint It's totally mine, I didn't check this case. Do you want me to fix it? |
Member
|
@pierrebelin PR is most welcome :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4127
Change finished executable succeed icon from warning to checkmark
Microsoft Reviewers: Open in CodeFlow