Skip to content

Set HTTP/HTTPS_PORTS on projects in publish mode#4404

Merged
davidfowl merged 12 commits intomicrosoft:mainfrom
davidebbo:set-http-ports
Jun 10, 2024
Merged

Set HTTP/HTTPS_PORTS on projects in publish mode#4404
davidfowl merged 12 commits intomicrosoft:mainfrom
davidebbo:set-http-ports

Conversation

@davidebbo
Copy link
Copy Markdown
Contributor

@davidebbo davidebbo commented Jun 6, 2024

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jun 6, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jun 6, 2024
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs Outdated
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs Outdated
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs Outdated
- Only do this for explicit endpoints, not from profile
- Fixes microsoft#3749
Comment thread tests/Aspire.Hosting.Tests/WithEndpointTests.cs Outdated
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs Outdated
Comment thread src/Aspire.Hosting/ProjectResourceBuilderExtensions.cs Outdated
Comment thread tests/Aspire.Hosting.Tests/WithEndpointTests.cs
@davidfowl davidfowl merged commit a1f0a59 into microsoft:main Jun 10, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set HTTP/HTTPS_PORTS on projects in publish mode by default

2 participants