Skip to content

Fix CredScan false positive.#4548

Merged
joperezr merged 1 commit intomicrosoft:mainfrom
joperezr:FixSecretFalsePositive
Jun 17, 2024
Merged

Fix CredScan false positive.#4548
joperezr merged 1 commit intomicrosoft:mainfrom
joperezr:FixSecretFalsePositive

Conversation

@joperezr
Copy link
Copy Markdown
Member

@joperezr joperezr commented Jun 17, 2024

Repo mirroring is broken currently because CredScan is flagging a false positive secret in the recent changes for FromDockerfile support. This PR fixes that by using a placeholder that is more clearly fake, as well as adding it to the suppressions file. All of the existing suppressions are mostly credentials, which is why I went with defining a new one instead of using an existing one.

cc: @mitchdenny @mmitche

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 17, 2024
@danmoseley
Copy link
Copy Markdown
Member

I believe the value "placeholder" Is automatically ignored, but this is fine too of course.

@joperezr
Copy link
Copy Markdown
Member Author

I believe the value "placeholder" Is automatically ignored, but this is fine too of course.

I didn't know that! That said, I think I slightly prefer being more explicit to note that something is fake, so I think I'll keep as is. If you feel strongly though, I'm happy to change.

@joperezr
Copy link
Copy Markdown
Member Author

Merging to unblock 8.1 builds.

@joperezr joperezr merged commit 552d0c1 into microsoft:main Jun 17, 2024
@danmoseley
Copy link
Copy Markdown
Member

danmoseley commented Jun 17, 2024

One problem with avoidable suppressions it is it defeats code reviews because I can't tell if something's real without reading the suppression file. Also the suppressions aren't location specific either so if I go today add a real secret p@ssw0rd1 into the code, credscan won't flag it because it's suppressed for some place it's used as a fake one.
Not suggesting you change this just making the observation.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 18, 2024
@joperezr joperezr deleted the FixSecretFalsePositive branch April 1, 2025 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants