Add some codeowners#4615
Merged
radical merged 3 commits intomicrosoft:mainfrom Jun 20, 2024
Merged
Conversation
radical
requested review from
DamianEdwards,
ReubenBond,
eerhardt,
joperezr and
mitchdenny
ghost
added
the
needs-area-label
Member
Author
|
I added a few, but please free to add more. |
radical
commented
Jun 20, 2024
| @@ -1 +1,16 @@ | |||
| /eng/SourceBuild* @dotnet/source-build-internal No newline at end of file | |||
| /eng/SourceBuild* @dotnet/source-build-internal | |||
Member
Author
There was a problem hiding this comment.
Why is github complaining about this? This line is same as in the other repos - https://github.com/dotnet/sdk/blob/7822425c3ea35e0bb46e57fad11663e7cbf9f850/CODEOWNERS#L106
Member
Author
There was a problem hiding this comment.
Unknown owner on line 1: make sure the team @dotnet/source-build-internal exists, is publicly visible, and has write access to the repository
/eng/SourceBuild* @dotnet/source-build-internal
Member
There was a problem hiding this comment.
Has that team been given any rights to this repo? I don't see it in the list.
Member
Author
There was a problem hiding this comment.
I guess not! Who can fix this?
Member
There was a problem hiding this comment.
I added that team with write permission
github-actions
Bot
added
area-codeflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow