Disable some hosting tests failing on CI#4653
Conversation
ghost
added
the
area-integrations
| } | ||
|
|
||
| [Fact] | ||
| [ActiveIssue("https://github.com/dotnet/aspire/issues/4651", typeof(PlatformDetection), nameof(PlatformDetection.IsRunningOnCI))] |
There was a problem hiding this comment.
Why isn't this
| [ActiveIssue("https://github.com/dotnet/aspire/issues/4651", typeof(PlatformDetection), nameof(PlatformDetection.IsRunningOnCI))] | |
| [ActiveIssue("https://github.com/dotnet/aspire/issues/4651")] |
?
If a test is flaky, I don't want it to fail on my machine locally only to realize it might be broken and not due to my changes.
There was a problem hiding this comment.
This was working fine earlier on local runs, and CI. But started to fail around the time we enabled docker based tests to run on the build machine. But I think this affected by other tests that run before this.
Instead of disabling this one, I will revert all the tests in tests/Aspire.Hosting.Tests/DistributedApplicationTests.cs which had [LocalOnly*] back to being local-only. This is what @mitchdenny suggested in #4142 (comment) too.
There was a problem hiding this comment.
I retained the attributed as-is on this test because it was also marked LocalOnly* earlier.
There was a problem hiding this comment.
@eerhardt I haven't heard from anyone about this test failing locally. But I can disable it for local too, if that's preferable.
There was a problem hiding this comment.
Merging this to get a green CI. But I can make this change in a follow up PR if you want.
There was a problem hiding this comment.
I haven't heard from anyone about this test failing locally.
My guess is that it isn't getting run as often locally as it is in CI.
My thinking is that CI machines are just normal computers. If we have races / flaky failures in our tests on CI, chances are we do locally too.
… run local only Some tests were enabled to run on CI in fb97eda but they might be responsible for some intermittent failures. This commit disables them till the issue can be fixed.
3 participants
Issues: #4650 and #4651
Microsoft Reviewers: Open in CodeFlow