[tests] Extract playwright bits to Playwright.targets, and separate class#4689
[tests] Extract playwright bits to Playwright.targets, and separate class#4689radical merged 6 commits intomicrosoft:mainfrom
Conversation
ghost
added
the
area-integrations
radical
force-pushed
the
playwright-targets
branch
2 times, most recently
from
a6a6fbe to
c138703
Compare
…lass to allow re-use outside the workload tests
radical
force-pushed
the
playwright-targets
branch
from
c138703 to
a6648e8
Compare
# Conflicts: # tests/Shared/WorkloadTesting/EnvironmentVariables.cs
| return; | ||
| } | ||
|
|
||
| if (repoRoot is null) |
There was a problem hiding this comment.
Does this case ever happen? If repoRoot is null its because we are in Helix, right?
There was a problem hiding this comment.
This one is if the caller didn't pass in a pre-computed repoRoot then we do the detection here. In BuildEnvironment.cs we already have repoRoot computed so this would avoid it being repeated. But when using it outside the workload tests, the caller might not have it, and thus pass null here.
But now that you mention it, I'm repeating this code in BuildEnvironment.cs . This should become a separate method .. somewhere!
There was a problem hiding this comment.
Extracted that to a TestUtils.FindRepoRoot.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…with Playwright.targets
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=723056&view=codecoverage-tab |
3 participants
... to allow re-use outside the workload tests.
Playwrightspecific msbuild bits totests/Shared/Playwright/tests/Shared/Playwright/Playwright.targetsto get support for installing the dependencies on build.Prompted by #4386 .
Microsoft Reviewers: Open in CodeFlow