Conversation
Member
Author
|
/azp run |
Member
Author
|
Please review 🙏 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
2341cae to
c0d7128
Compare
c0d7128 to
2938f06
Compare
radical
reviewed
Jul 3, 2024
radical
approved these changes
Jul 3, 2024
Member
radical
left a comment
There was a problem hiding this comment.
I'm not really familiar with the code. But diff seems to do what the PR description says, and makes sense to me - whatever I could understand!
adamint
reviewed
Jul 3, 2024
| { | ||
| _contextAttributes = | ||
| [ | ||
| new KeyValuePair<string, string>("Source", ViewModel.Span.Scope.ScopeName) |
Member
There was a problem hiding this comment.
is there a reason these are hardcoded?
Member
Author
There was a problem hiding this comment.
Are you asking why the names aren't in resource files for translation? None of the "known" property names in the details screens are translated because none of the properties that come from OTEL are translated.
Member
|
|
Member
Author
|
I included a fix in another PR: |
Member
Cool, assuming that it is ready to merge once CI is green. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3711
While making other repository changes I noticed that the source was on the trace instead of span. Moved it, and added the UI to display a context section to span details. The new section includes the span's source (in .NET land, this is the activity source name such as
Microsoft.AspNetCoreorSystem.Net.Http), parent id and trace id.Microsoft Reviewers: Open in CodeFlow