Skip to content

[tests] Some Playwright related fixes#4726

Merged
radical merged 2 commits intomicrosoft:mainfrom
radical:playwright-fixes
Jul 2, 2024
Merged

[tests] Some Playwright related fixes#4726
radical merged 2 commits intomicrosoft:mainfrom
radical:playwright-fixes

Conversation

@radical
Copy link
Copy Markdown
Member

@radical radical commented Jun 28, 2024

PR #4694 incorrectly disabled playwright tests when they should have been running. This inverts the condition to correctly disable for the failing case.

Related: #4623

  • [tests] Move HasPlaywrightSupport to PlaywrightProvider class
  • Fix condition disabling playwright based tests
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 28, 2024
@radical radical force-pushed the playwright-fixes branch from 9436b9e to d840250 Compare June 29, 2024 00:19
@radical radical marked this pull request as ready for review June 29, 2024 00:26
@radical radical requested a review from eerhardt as a code owner June 29, 2024 00:26
Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical radical merged commit 7166a5e into microsoft:main Jul 2, 2024
@radical radical deleted the playwright-fixes branch July 2, 2024 19:19
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants