Skip to content

Docs to cover 6006.#6097

Merged
davidfowl merged 2 commits intomainfrom
mitchdenny/docs-to-cover-6006
Jan 25, 2025
Merged

Docs to cover 6006.#6097
davidfowl merged 2 commits intomainfrom
mitchdenny/docs-to-cover-6006

Conversation

@mitchdenny
Copy link
Copy Markdown
Member

@mitchdenny mitchdenny commented Oct 4, 2024

Description

Adding some remarks to WithEndpoint(callback) to explain why setting protocol doesn't update urischeme automatically.

Fixes #6006

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny self-assigned this Oct 4, 2024
@mitchdenny mitchdenny added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Oct 4, 2024
@mitchdenny mitchdenny added this to the 9.0 milestone Oct 4, 2024
@mitchdenny
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Copy Markdown
Contributor

It should update the scheme.

@mitchdenny
Copy link
Copy Markdown
Member Author

That would make it order dependent.

@davidfowl
Copy link
Copy Markdown
Contributor

We should set the scheme when you set the protocol (in the property setter). We do the same wtih port and target port (if target port is unset)

@joperezr joperezr modified the milestones: 9.0, 9.1 Jan 9, 2025
@joperezr joperezr assigned danmoseley and unassigned mitchdenny Jan 13, 2025
@davidfowl davidfowl enabled auto-merge (squash) January 25, 2025 05:03
@davidfowl davidfowl merged commit d7e9d2f into main Jan 25, 2025
@davidfowl davidfowl deleted the mitchdenny/docs-to-cover-6006 branch January 25, 2025 06:14
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Endpoints registered as UDP show as TCP

5 participants