Skip to content

Tweak dashboard title padding#6722

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/dashboard-padding
Nov 29, 2024
Merged

Tweak dashboard title padding#6722
JamesNK merged 1 commit intomainfrom
jamesnk/dashboard-padding

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Nov 19, 2024

Description

Slightly reduce the left padding of the dashboard title/toolbar/footer, etc (4px).

After:

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@drewnoakes
Copy link
Copy Markdown
Member

What's the rationale for this change? The left alignment looks strange:

image

There are three lines in the "grid system" here, where there should probably be one.

image

@JamesNK JamesNK force-pushed the jamesnk/dashboard-padding branch from 2578814 to e9596e6 Compare November 22, 2024 01:22
@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 22, 2024

I changed the overall title (TestShop) to line up with the page title after taking the screenshot. This is what I see:

image

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 22, 2024

The reason for the change is I felt indenting the titles and all other page content to line up with the grid (18px) indent was too much.

Do you prefer everything lines up?

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 22, 2024

I went through every page and tried to line everything up as much as possible inside the content area (dark grey area). The one exception, which is outside that area, is the app name next to the Aspire logo.

I think the app name looks fine not lined up with inner page content. Also, I went out and looked at other web apps and they don't attempt to line up the app name.

@JamesNK JamesNK force-pushed the jamesnk/dashboard-padding branch from 5329534 to 275d39e Compare November 27, 2024 05:42
@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 27, 2024

Ping @drewnoakes @adamint

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 27, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 28, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Nov 28, 2024

/azp run

@JamesNK JamesNK enabled auto-merge (squash) November 28, 2024 02:32
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK force-pushed the jamesnk/dashboard-padding branch from f69b851 to 37c79cd Compare November 29, 2024 02:20
@JamesNK JamesNK merged commit d9a9826 into main Nov 29, 2024
@JamesNK JamesNK deleted the jamesnk/dashboard-padding branch November 29, 2024 03:42
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants