Skip to content

Clean up resource builder extensions XML docs#6753

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/resourcebuilder-docs-cleanup
Nov 22, 2024
Merged

Clean up resource builder extensions XML docs#6753
JamesNK merged 1 commit intomainfrom
jamesnk/resourcebuilder-docs-cleanup

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Nov 21, 2024

Description

  • Fix some examples
  • Make return consistent

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 21, 2024
@JamesNK JamesNK requested a review from mitchdenny November 21, 2024 08:47
IEvangelist added a commit that referenced this pull request Nov 22, 2024
@JamesNK JamesNK merged commit c937d6c into main Nov 22, 2024
@JamesNK JamesNK deleted the jamesnk/resourcebuilder-docs-cleanup branch November 22, 2024 01:01
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants