Skip to content

Remove inner exception from RMQ Logger when empty#6836

Merged
eerhardt merged 3 commits intomicrosoft:mainfrom
RafaelJCamara:bug/remove-inner-exception-when-empty
Dec 9, 2024
Merged

Remove inner exception from RMQ Logger when empty#6836
eerhardt merged 3 commits intomicrosoft:mainfrom
RafaelJCamara:bug/remove-inner-exception-when-empty

Conversation

@RafaelJCamara
Copy link
Copy Markdown
Contributor

@RafaelJCamara RafaelJCamara commented Nov 28, 2024

Description

There was a problem described in #2967 where an empty inner exception was being rendered.
What I've done was adjust the Count property to take the empty property into consideration.
Tests for empty and non-empty inner exceptions were added.

This is now the final result:
0

Fixes partially #2967

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Nov 28, 2024
Comment thread src/Components/Aspire.RabbitMQ.Client/RabbitMQEventSourceLogForwarder.cs Outdated
@RafaelJCamara
Copy link
Copy Markdown
Contributor Author

I solved merge conflicts on my latest commit.
Things still work as before:
image

Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@eerhardt eerhardt merged commit 145d70e into microsoft:main Dec 9, 2024
@RafaelJCamara RafaelJCamara deleted the bug/remove-inner-exception-when-empty branch December 9, 2024 17:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 9, 2025
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants