Skip to content

Consistent language order in dropdown#6923

Merged
adamint merged 3 commits intomainfrom
jamesnk/culture-order
Dec 10, 2024
Merged

Consistent language order in dropdown#6923
adamint merged 3 commits intomainfrom
jamesnk/culture-order

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Dec 10, 2024

Description

I noticed the order of languages in the language dropdown changed based on the selected language. We want the order to be consistent here so use the invariant culture to provide a consistent dropdown of values.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@adamint adamint merged commit 6c297ab into main Dec 10, 2024
@adamint adamint deleted the jamesnk/culture-order branch December 10, 2024 15:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants