Add IServiceProvider to Nats Client Extensions#6929
Merged
eerhardt merged 2 commits intomicrosoft:mainfrom Dec 13, 2024
Merged
Conversation
eerhardt
reviewed
Dec 11, 2024
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
eerhardt
approved these changes
Dec 13, 2024
Member
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Nats client extensions with
IServiceProviderto allow configuring services from the DI container, similar to changes made for Kafka in (see PR discussion):Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):Microsoft Reviewers: Open in CodeFlow