Skip to content

Add IServiceProvider to Nats Client Extensions#6929

Merged
eerhardt merged 2 commits intomicrosoft:mainfrom
larsfjerm:nats-sp-client-extensions
Dec 13, 2024
Merged

Add IServiceProvider to Nats Client Extensions#6929
eerhardt merged 2 commits intomicrosoft:mainfrom
larsfjerm:nats-sp-client-extensions

Conversation

@larsfjerm
Copy link
Copy Markdown
Contributor

@larsfjerm larsfjerm commented Dec 11, 2024

Description

Add Nats client extensions with IServiceProvider to allow configuring services from the DI container, similar to changes made for Kafka in (see PR discussion):

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Dec 11, 2024
Comment thread src/Components/Aspire.NATS.Net/AspireNatsClientExtensions.cs
Comment thread src/Components/Aspire.NATS.Net/AspireNatsClientExtensions.cs Outdated
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@eerhardt eerhardt merged commit 3991282 into microsoft:main Dec 13, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 13, 2025
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants