Skip to content

Position the language listbox to bottom to fix cutoff#6972

Merged
adamint merged 4 commits intomicrosoft:mainfrom
adamint:dev/adamint/fix-languages-cut-off-small-browser
Jan 24, 2025
Merged

Position the language listbox to bottom to fix cutoff#6972
adamint merged 4 commits intomicrosoft:mainfrom
adamint:dev/adamint/fix-languages-cut-off-small-browser

Conversation

@adamint
Copy link
Copy Markdown
Member

@adamint adamint commented Dec 19, 2024

Description

Displays the language select listbox to the bottom of the select, we always see a scrollbar and all options are visible.

image

Fixes #6941 - occurred only with small height, large width viewports

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

Copy link
Copy Markdown
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. But I don't like the horizontal scroll bar. Add min-width: 240px; to the fluent select to fix this. Put a class on the select and move the styles to a class.

@adamint adamint enabled auto-merge (squash) January 23, 2025 18:29
@adamint adamint force-pushed the dev/adamint/fix-languages-cut-off-small-browser branch from ae087fd to 13bf27d Compare January 23, 2025 18:44
@JamesNK
Copy link
Copy Markdown
Member

JamesNK commented Jan 24, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@adamint adamint merged commit d4e8d9f into microsoft:main Jan 24, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[WebToolsE2E][Aspire] When the browser page is zoomed out, the Language in Aspire Dashboard Settings only displays four languages.

3 participants