Skip to content

Reject invalid histogram data points#6998

Merged
JamesNK merged 3 commits intomainfrom
jamesnk/metrics-improve-failure-handling
Jan 13, 2025
Merged

Reject invalid histogram data points#6998
JamesNK merged 3 commits intomainfrom
jamesnk/metrics-improve-failure-handling

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Dec 30, 2024

Description

Fixes #6962

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
Microsoft Reviewers: Open in CodeFlow

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Dashboard/Otlp/Model/MetricValues/DimensionScope.cs:110

  • [nitpick] The error message could be more informative by including the metric name or context.
throw new InvalidOperationException($"Histogram data point has more bucket counts than explicit bounds. Bucket counts: {bucketCounts.Length}, explicit bounds: {explicitBounds.Length}");

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 3, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 8, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 9, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 9, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/Aspire.Dashboard/Otlp/Model/OtlpApplication.cs
Comment thread src/Aspire.Dashboard/Otlp/Model/OtlpApplication.cs Outdated
Copy link
Copy Markdown
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more question.

@JamesNK JamesNK force-pushed the jamesnk/metrics-improve-failure-handling branch from 9c5beb2 to 241cb9f Compare January 13, 2025 02:02
@JamesNK JamesNK enabled auto-merge (squash) January 13, 2025 02:03
@JamesNK JamesNK merged commit 882ae2b into main Jan 13, 2025
@JamesNK JamesNK deleted the jamesnk/metrics-improve-failure-handling branch January 13, 2025 03:06
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-dashboard area-telemetry Telemetry from the Aspire app to the dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

micrometer http.server.requests metric breaks metrics UI with IndexOutOfRangeException

3 participants