Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Aspire.Dashboard/Components/Controls/StructuredLogDetails.razor.cs:99
- The word 'desintation' is misspelled. It should be 'destination'.
private static void MoveAttributes(List<TelemetryPropertyViewModel> source, List<TelemetryPropertyViewModel> desintation, Func<TelemetryPropertyViewModel, bool> predicate)
src/Aspire.Dashboard/Components/Controls/StructuredLogDetails.razor.cs:86
- The new behavior introduced in the OnAfterRenderAsync method should be covered by tests to ensure it works as expected.
protected override async Task OnAfterRenderAsync(bool firstRender)
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
adamint
approved these changes
Jan 9, 2025
e1d004a to
d9a6133
Compare
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switching details item while the details view is open (e.g. clicking between resources on resources page) doesn't reset the scroll position. The reason this happens is Blazor rerenders the content of the scroll container, but leaves the container unchanged, preserving scroll position.
The user impact of this bug is if you view a resource's details, scroll down in the details, then click another resource, the other resource is also scrolled. This bug also impacts log and span details.
This PR tracks when the data has changed, and invokes JS to reset the details view scrollbar to the top after render.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):