Skip to content

Fix CosmosDb sample endpoint in xml docs#7065

Merged
eerhardt merged 1 commit intomainfrom
sebros/cosmosxmldoc
Jan 10, 2025
Merged

Fix CosmosDb sample endpoint in xml docs#7065
eerhardt merged 1 commit intomainfrom
sebros/cosmosxmldoc

Conversation

@sebastienros
Copy link
Copy Markdown
Contributor

Description

I believe this was taken from storage queues. I followed the patter from https://learn.microsoft.com/en-us/rest/api/cosmos-db/cosmosdb-resource-uri-syntax-for-rest instead.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@sebastienros sebastienros requested review from Pilchie and eerhardt and removed request for eerhardt and radical January 10, 2025 17:41
@eerhardt
Copy link
Copy Markdown
Member

Merging as this is docs only and it is a waste of resources to try to get a passing CI run with our flakey tests.

@eerhardt eerhardt merged commit d5dd55d into main Jan 10, 2025
@eerhardt eerhardt deleted the sebros/cosmosxmldoc branch January 10, 2025 19:40
Copy link
Copy Markdown
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2025
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants