Skip to content

Log container runtime unhealthy or missing as warning#7113

Merged
JamesNK merged 1 commit intomainfrom
jamesnk/container-runtime-health-log-level
Jan 15, 2025
Merged

Log container runtime unhealthy or missing as warning#7113
JamesNK merged 1 commit intomainfrom
jamesnk/container-runtime-health-log-level

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Jan 15, 2025

Description

After:

image

Fixes #6655

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 15, 2025
@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 15, 2025

Here is what it looks like with error instead:

image

Thinking about this more, I like error as the level.

  • Critical = app will crash and exit
  • Error = wrong and broken
  • Warning = wrong but you can ignore if you want

If you have an app with a container, and the container isn't running, your app most likely is in an error state. You must start the container runtime for all your resources to run.

@JamesNK JamesNK merged commit 9cbe012 into main Jan 15, 2025
@JamesNK JamesNK deleted the jamesnk/container-runtime-health-log-level branch January 15, 2025 02:46
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Container runtime not found log message level

2 participants