Added support for publish projects as docker files as well.#7115
Merged
Added support for publish projects as docker files as well.#7115
Conversation
- This is to round out our support for exe/project -> dockerfile
eerhardt
reviewed
Jan 15, 2025
Comment on lines
+665
to
+668
| // Even through we're adding a ContainerResource | ||
| // update the manifest publishing callback on the original ProjectResource | ||
| // so that the container resource is written to the manifest | ||
| return builder.WithManifestPublishingCallback(context => |
Member
There was a problem hiding this comment.
How does the original project's manifest publishing callback get invoked? We removed it from the ApplicationBuilder.
Contributor
Author
There was a problem hiding this comment.
The reference is in user code, this is just a fail safe.
eerhardt
approved these changes
Jan 15, 2025
3 tasks
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We added support for publishing an executable as a container image, this does the same for projects.
Follow up to #7072
Fixes #3825
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):