Skip to content

Allow starting waiting resources#7161

Merged
davidfowl merged 4 commits intomainfrom
jamesnk/start-waiting-resources
Jan 25, 2025
Merged

Allow starting waiting resources#7161
davidfowl merged 4 commits intomainfrom
jamesnk/start-waiting-resources

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Jan 20, 2025

Description

Addresses #5879

Previously Waiting resources could not start until the resource they are waiting on became healthy. The resource would wait and the "Start" button was disabled.

This PR enables the resource-start custom act for waiting resources. That makes it possible to click on the "Start" button for a waiting resources to explicitly start before its dependencies are healthy.

Note that this change doesn't tell lower-level app host code that is waiting for a healthy event to stop waiting. That also needs to be done (either in this PR or a future PR) to properly clean up state when "Start" is clicked.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 20, 2025
@JamesNK JamesNK requested review from davidfowl and eerhardt January 20, 2025 05:31
@JamesNK JamesNK requested a review from mitchdenny as a code owner January 20, 2025 05:31
@davidfowl
Copy link
Copy Markdown
Contributor

I expected a much bigger refactoring that changes the state machine to make it possible to not only stop waiting but restart and enter the waiting state again

@davidfowl
Copy link
Copy Markdown
Contributor

@JamesNK is this PR still valid?

@davidfowl
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK force-pushed the jamesnk/start-waiting-resources branch from 1d9342f to 10240d3 Compare January 25, 2025 12:20
@davidfowl
Copy link
Copy Markdown
Contributor

Note that this change doesn't tell lower-level app host code that is waiting for a healthy event to stop waiting. That also needs to be done (either in this PR or a future PR) to properly clean up state when "Start" is clicked.

@JamesNK do you want to treat that issue as fixed or file another one for this follow up?

@davidfowl davidfowl merged commit d2ca15d into main Jan 25, 2025
@davidfowl davidfowl deleted the jamesnk/start-waiting-resources branch January 25, 2025 15:28
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants