Merged
Conversation
Contributor
|
I expected a much bigger refactoring that changes the state machine to make it possible to not only stop waiting but restart and enter the waiting state again |
Contributor
|
@JamesNK is this PR still valid? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1d9342f to
10240d3
Compare
Contributor
@JamesNK do you want to treat that issue as fixed or file another one for this follow up? |
davidfowl
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #5879
Previously
Waitingresources could not start until the resource they are waiting on became healthy. The resource would wait and the "Start" button was disabled.This PR enables the
resource-startcustom act for waiting resources. That makes it possible to click on the "Start" button for a waiting resources to explicitly start before its dependencies are healthy.Note that this change doesn't tell lower-level app host code that is waiting for a healthy event to stop waiting. That also needs to be done (either in this PR or a future PR) to properly clean up state when "Start" is clicked.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):