Skip to content

Set EnvironmentCallbackContext.Logger to NullLogger by default#7180

Merged
davidfowl merged 1 commit intomicrosoft:mainfrom
matthebrown:FixEnvironmentCallbackContextLogger
Jan 20, 2025
Merged

Set EnvironmentCallbackContext.Logger to NullLogger by default#7180
davidfowl merged 1 commit intomicrosoft:mainfrom
matthebrown:FixEnvironmentCallbackContextLogger

Conversation

@matthebrown
Copy link
Copy Markdown
Contributor

@matthebrown matthebrown commented Jan 20, 2025

Description

Sets EnvironmentCallbackContext.Logger to NullLogger by default.

Fixes #4517

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jan 20, 2025
@davidfowl davidfowl enabled auto-merge (squash) January 20, 2025 19:07
@matthebrown
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 7180 in repo dotnet/aspire

@davidfowl
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit 224171e into microsoft:main Jan 20, 2025
@matthebrown matthebrown deleted the FixEnvironmentCallbackContextLogger branch January 20, 2025 23:29
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 20, 2025
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnvironmentCallbackContext.Logger doesn't need to be nullable

2 participants