Skip to content

Use withHttpCheck for signalr emulator health check#7202

Merged
davidfowl merged 2 commits intomicrosoft:mainfrom
cqnguy23:use-http-health-check-for-signalr
Jan 22, 2025
Merged

Use withHttpCheck for signalr emulator health check#7202
davidfowl merged 2 commits intomicrosoft:mainfrom
cqnguy23:use-http-health-check-for-signalr

Conversation

@cqnguy23
Copy link
Copy Markdown
Contributor

@cqnguy23 cqnguy23 commented Jan 22, 2025

Description

  • Use .withHttpCheck for signalr emulator health check instead of creating a custom health check

Fixes #6676

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Jan 22, 2025
Comment thread src/Aspire.Hosting.Azure.SignalR/AzureSignalRExtensions.cs Outdated
@davidfowl davidfowl merged commit 405a54b into microsoft:main Jan 22, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2025
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add RunAsEmulator() method to wire up Azure SignalR's local emulator

2 participants