Add detailed Docker container information to pre/post test run commands#7222
Merged
Add detailed Docker container information to pre/post test run commands#7222
Conversation
The detailed info includes network connections in particular, which will help us diagnose lingering "default-aspire-network" networks.
karolz-ms
commented
Jan 23, 2025
|
|
||
| <ItemGroup Condition="'$(HasDocker)' == 'true'"> | ||
| <HelixPreCommand Include="docker info" /> | ||
| <HelixPreCommand Include="docker ps" /> |
Contributor
Author
There was a problem hiding this comment.
docker ps is the same as docker container ls
karolz-ms
commented
Jan 23, 2025
| <ItemGroup Condition="'$(HasDocker)' == 'true'"> | ||
| <HelixPreCommand Include="docker info" /> | ||
| <HelixPreCommand Include="docker ps" /> | ||
| <HelixPreCommand Include="docker container ls --all" /> |
Contributor
Author
There was a problem hiding this comment.
Leaving both table and JSON output from docker container ls because non-JSON (table) output is easy on the eyes (allows to quickly check if something was left hanging).
Contributor
|
MERGE |
Contributor
|
This isn't working. I think json needs a format string: |
Contributor
|
Hmm running locally it works, I don't know why helix is printing the text "json". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detailed info includes network connections in particular, which will help us diagnose lingering "default-aspire-network" networks.