Add snapshot version tracking and improve logging#7233
Merged
Conversation
- Introduced a new `Id` property in `CustomResourceSnapshot` for unique identification of snapshots. - Updated `WatchAsync` to filter resource events based on the maximum snapshot ID. - Modified `PublishUpdateAsync` to increment the snapshot ID for new states. - Enhanced logging in `PublishUpdateAsync` to include the new snapshot ID for better traceability.
JamesNK
reviewed
Jan 24, 2025
davidfowl
changed the title
JamesNK
approved these changes
Jan 24, 2025
Member
JamesNK
left a comment
JamesNK
left a comment
There was a problem hiding this comment.
I think this is ok.
I think we should consider having some kind of stress test for the notification service that blasts it with load in various situations and verifies it still works. Doesn't need to happen now.
This was referenced Jan 24, 2025
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idproperty inCustomResourceSnapshotfor unique identification of snapshots.WatchAsyncto filter resource events based on the maximum snapshot ID.PublishUpdateAsyncto increment the snapshot ID for new states.PublishUpdateAsyncto include the new snapshot ID for better traceability.