Support referencing existing Service Bus resources in references#7249
Merged
captainsafia merged 11 commits intomainfrom Feb 3, 2025
Merged
Support referencing existing Service Bus resources in references#7249captainsafia merged 11 commits intomainfrom
captainsafia merged 11 commits intomainfrom
Conversation
Contributor
This should be a draft right? |
davidfowl
reviewed
Jan 25, 2025
davidfowl
reviewed
Jan 25, 2025
captainsafia
commented
Jan 25, 2025
davidfowl
reviewed
Jan 25, 2025
davidfowl
reviewed
Jan 25, 2025
davidfowl
reviewed
Jan 25, 2025
davidfowl
reviewed
Jan 25, 2025
eerhardt
reviewed
Jan 27, 2025
eerhardt
reviewed
Jan 27, 2025
eerhardt
reviewed
Jan 27, 2025
eerhardt
reviewed
Jan 27, 2025
eerhardt
reviewed
Jan 27, 2025
| } | ||
|
|
||
| [Fact] | ||
| public async Task RequiresPublishAsExistingInPublishMode() |
Member
There was a problem hiding this comment.
(nit) Is this test name correct? the test calls RunAsExisting
Contributor
Author
There was a problem hiding this comment.
Yeah, the test name is correct although confusing. I was intending to say that you need to call PublishAsExisting in publish-mode otherwise the API effectively no-ops.
eerhardt
reviewed
Jan 27, 2025
eerhardt
reviewed
Jan 27, 2025
eerhardt
reviewed
Jan 27, 2025
| @@ -86,7 +96,7 @@ public static IResourceBuilder<AzureServiceBusResource> AddAzureServiceBus(this | |||
| infrastructure.Add(cdkRule); | |||
Member
There was a problem hiding this comment.
Does generating these Queues and Topics work with an existing resource?
davidfowl
reviewed
Jan 27, 2025
3 tasks
eerhardt
approved these changes
Feb 3, 2025
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Looks really good. Nice work @captainsafia.
davidfowl
reviewed
Feb 3, 2025
| // This could be done as a bicep template that imports the other bicep template but this is | ||
| // quick and dirty for now | ||
| var keyVaults = context.ResourceGroup.GetKeyVaults(); | ||
| var keyVaults = resourceGroup.GetKeyVaults(); |
Contributor
There was a problem hiding this comment.
Testing this code path is interesting...
davidfowl
reviewed
Feb 3, 2025
Comment on lines
+67
to
+70
| if (builder.Resource.IsExisting()) | ||
| { | ||
| throw new InvalidOperationException($"Resource {builder.Resource.Name} is already marked as an existing resource."); | ||
| } |
Contributor
There was a problem hiding this comment.
Why throw instead of replace?
Contributor
Author
There was a problem hiding this comment.
I feel like it makes it clearer to reason through the scope a resource is grouped to if we only support one XAsExisting invocation on a resource.
Contributor
There was a problem hiding this comment.
We need to think about this like a pipeline. It should not throw
…isting-resources-1
davidfowl
reviewed
Feb 3, 2025
| /// </summary> | ||
| /// <remarks> | ||
| /// The scope is a weakly-typed collection of key-value pairs that can be used to configure | ||
| /// the Bicep scope that is emitted by AZD in the module definition for a resource. |
davidfowl
reviewed
Feb 3, 2025
| /// versions azure.bicep.v1. Only the `resourceGroup` key is respected as a sub-property although | ||
| /// more keys may be supported in the future, such as a subscriptionId. | ||
| /// </remarks> | ||
| public Dictionary<string, object> Scope { get; } = []; |
This was referenced Feb 4, 2025
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this PR to sanity check the approach before adding it to other resource types. Some things of note:
FromExistingmethods should support setting scopes Azure/azure-sdk-for-net#47980. There are workarounds for the but the juice might not be worth the squeeze.ConfigureInfrastructurecalls for each resource.