Conversation
- Passwords were not working well, in fact, it was a fluke they work in some cases Fixes 7296
eerhardt
reviewed
Jan 28, 2025
| var passwordParameter = builder1.AddParameter("pwd"); | ||
| builder1.Configuration["Parameters:user"] = username; | ||
| builder1.Configuration["Parameters:pwd"] = password; | ||
| var usernameParameter = builder1.AddParameter("user", username); |
Member
There was a problem hiding this comment.
I like this new code, it is much simpler now that we have these overloads.
But can you help me understand what wasn't working before this change? Adding the Parameter and setting the value via the Configuration should just work.
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7296