Skip to content

Fix resource filter not adding new values on update#7300

Merged
davidfowl merged 2 commits intomainfrom
jamesnk/fix-resource-filter-again
Jan 28, 2025
Merged

Fix resource filter not adding new values on update#7300
davidfowl merged 2 commits intomainfrom
jamesnk/fix-resource-filter-again

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Jan 28, 2025

Description

Fixes regression from #6925. It didn't update the filters with new values as resources updated. Stopping a resource would cause it to disappear:

  1. Filter only allows Starting and Running
  2. Resource is updated to Stopping. Filter isn't updated to view.
  3. Resource disappears from UI.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK
Copy link
Copy Markdown
Member Author

JamesNK commented Jan 28, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl davidfowl merged commit 00da009 into main Jan 28, 2025
@davidfowl davidfowl deleted the jamesnk/fix-resource-filter-again branch January 28, 2025 16:25
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2025
@JamesNK JamesNK review requested due to automatic review settings March 23, 2026 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants