Fix AddParameter usage in tests#7305
Merged
eerhardt merged 1 commit intomicrosoft:mainfrom Jan 28, 2025
Merged
Conversation
When adding the parameter first, and then setting the config, it accidently works because an exception is thrown at first and then the value is retrieved later when the config is set. Fix this by ensuring the configuration is set first, before calling AddParameter. For hosting tests for hosting integrations that aren't part of the core/base APIs, I changed the tests to be simple and just pass the constant value into AddParameter.
sebastienros
approved these changes
Jan 28, 2025
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the parameter first, and then setting the config, it accidently works because an exception is thrown at first and then the value is retrieved later when the config is set.
Fix this by ensuring the configuration is set first, before calling AddParameter.
For hosting tests for hosting integrations that aren't part of the core/base APIs, I changed the tests to be simple and just pass the constant value into AddParameter.
This is a follow-up to #7297.