Don't wait for parameter/connection string resources#7314
Merged
Conversation
- Skip from waiting on them at the annotation level Fixes #6858
davidfowl
requested review from
JamesNK and
Copilot
and removed request for
mitchdenny
JamesNK
approved these changes
Jan 29, 2025
| // Parameters and connection string resources are inert and don't need to be waited on. | ||
| // If we add support for parameter resources that can be waited on, we can remove this check. | ||
| // As of right now, we don't support waiting on parameter resources. | ||
| continue; |
Member
There was a problem hiding this comment.
Write a warning log message? Let people know they're doing it wrong.
Contributor
Author
There was a problem hiding this comment.
Can't yet. Take a look at the issue, this pattern is from our docs.
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parameter resources do not have a lifecycle and it's not possible to wait on them today, yet this hangs. This PR special cases those for now but that's not the long-term solution. We need a design to let the system know when resources do or don't have a lifecycle (or we need to be able to detect terminal states). I chose to unblock this scenario for now with simpler code because it affects a key scenario: Using existing resources.
Fixes #6858
Checklist