Skip to content

Refactor to reuse polly pipelines and avoid 20 second test time#7323

Merged
JamesNK merged 2 commits intomainfrom
jamesnk/pipeline-refactor
Jan 30, 2025
Merged

Refactor to reuse polly pipelines and avoid 20 second test time#7323
JamesNK merged 2 commits intomainfrom
jamesnk/pipeline-refactor

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Jan 30, 2025

Description

Small optimization to reuse polly pipelines. Pipelines now created once rather than each time they're used.

Also DcpExecutorTests.ErrorIfResourceNotDeletedBeforeRestart was taking 20 seconds to run because of retries. Setting an empty pipeline allows it to complete immediately.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 30, 2025
@JamesNK JamesNK requested review from davidfowl and eerhardt January 30, 2025 02:25
@JamesNK JamesNK requested a review from mitchdenny as a code owner January 30, 2025 02:25
@JamesNK JamesNK merged commit 0ee094c into main Jan 30, 2025
@JamesNK JamesNK deleted the jamesnk/pipeline-refactor branch January 30, 2025 08:19
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants