Merged
Conversation
- Calling AddConnectionString would add a parameter resource the wrap it in surrogate. That's fine if nothing looks at the "runtime type" and always looks at the contract. The testing infrastructure has a method GetConnectionStringAsync that takes a resource name and it explodes in this case since the runtime type does not implement IResourceWithConnectionString. This fixes it by implementig that adding the surrogate directly as a parameter resource. - Added tests
davidfowl
added a commit
that referenced
this pull request
Feb 10, 2025
- After #7327, AddConnectionStrnig was generating a value.v0 resource instead of a parameter.v0. This fixes the order of evaluation so that parameters are preferred over IResourceWithConnectionString.
7 tasks
eerhardt
pushed a commit
that referenced
this pull request
Feb 10, 2025
- After #7327, AddConnectionStrnig was generating a value.v0 resource instead of a parameter.v0. This fixes the order of evaluation so that parameters are preferred over IResourceWithConnectionString.
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling AddConnectionString would add a parameter resource the wrap it in surrogate. That's fine if nothing looks at the "runtime type" and always looks at the contract. The testing infrastructure has a method GetConnectionStringAsync that takes a resource name and it explodes in this case since the runtime type does not implement IResourceWithConnectionString. This fixes it by implementing that adding the surrogate directly as a parameter resource.
Added tests
Fixes #7138
Checklist