Skip to content

Enable ServiceBus Emulator tests in CI#7331

Merged
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:EnableSBEmulatorTests
Jan 31, 2025
Merged

Enable ServiceBus Emulator tests in CI#7331
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:EnableSBEmulatorTests

Conversation

@eerhardt
Copy link
Copy Markdown
Member

Checking to see if these tests are more stable now.

@eerhardt
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Copy Markdown
Member Author

@sebastienros @davidfowl - these tests passed 2x in a row. Going for 3 now. When do you think we should try turning them back on?

@eerhardt
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Copy Markdown
Member Author

passed 3x

@sebastienros
Copy link
Copy Markdown
Contributor

Now that they have the correct timeouts and WaitFors it's probably helping. I am ok re-enabling them and monitor.

@eerhardt eerhardt marked this pull request as ready for review January 30, 2025 20:41
@eerhardt
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Copy Markdown
Member Author

Running one more time. If it passes 4x in a row, let's merge and see what happens when it runs a bunch. We can always revert this change as soon as we see them flaking out.

@eerhardt
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt
Copy link
Copy Markdown
Member Author

One last time. Enabling auto-merge now and it will merge on pass.

@eerhardt eerhardt enabled auto-merge (squash) January 31, 2025 02:51
@eerhardt eerhardt merged commit e6d4999 into microsoft:main Jan 31, 2025
eerhardt added a commit to eerhardt/aspire that referenced this pull request Feb 1, 2025
This reverts commit e6d4999.

These tests are still flakey. Re-disabling.
davidfowl pushed a commit that referenced this pull request Feb 1, 2025
This reverts commit e6d4999.

These tests are still flakey. Re-disabling.
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 3, 2025
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants