Update display name and description for built-in lifecycle commands#7334
Merged
adamint merged 6 commits intomicrosoft:mainfrom Feb 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (16)
- src/Aspire.Dashboard/Aspire.Dashboard.csproj: Language not supported
- src/Aspire.Dashboard/Resources/Commands.Designer.cs: Language not supported
- src/Aspire.Dashboard/Resources/Commands.resx: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.cs.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.de.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.es.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.fr.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.it.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.ja.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.ko.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.pl.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.pt-BR.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.ru.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.tr.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.zh-Hans.xlf: Language not supported
- src/Aspire.Dashboard/Resources/xlf/Commands.zh-Hant.xlf: Language not supported
drewnoakes
reviewed
Feb 5, 2025
| .ToImmutableArray(); | ||
|
|
||
| // Use custom localizations for built-in lifecycle commands | ||
| static (string DisplayName, string DisplayDescription) GetDisplayNameAndDescription(string commandName, string displayName, string description) |
Member
There was a problem hiding this comment.
I thought we were going to add localized values to the proto, so that other resource services (like that in ACA) can also have localized command strings.
Member
There was a problem hiding this comment.
I see James suggested this approach in the linked issue. I don't think it'd be too bad to add support for this to the proto. I would expect ACA to have loc requirements. cc @snehapar9
Member
Author
There was a problem hiding this comment.
This is a temporary solution for 9.1, we can improve this later @drewnoakes
Member
Member
Author
JamesNK
approved these changes
Feb 7, 2025
JamesNK
reviewed
Feb 7, 2025
Member
|
Good to merge once changes above are made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6982 - sets the display name and description for the three lifecycle commands in the resource service
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):