Skip to content

Add the ability to set parent relationships in the dashboard#7337

Merged
davidfowl merged 5 commits intomicrosoft:mainfrom
eerhardt:NestSidecar
Feb 1, 2025
Merged

Add the ability to set parent relationships in the dashboard#7337
davidfowl merged 5 commits intomicrosoft:mainfrom
eerhardt:NestSidecar

Conversation

@eerhardt
Copy link
Copy Markdown
Member

@eerhardt eerhardt commented Jan 30, 2025

Description

Add a new API - WithParentRelationship that can be set to nest resources.

Fix an issue in snapshot properties where it was overwriting previous properties by setting to
a new collection on publish. Needs to update/append to the property collection.

Allow Projects to be parents, not just Containers.

Fix #7259

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@eerhardt eerhardt requested a review from davidfowl January 30, 2025 23:40
Add a new API - WithParentRelationship that can be set to nest resources.

Fix an issue in snapshot properties where it was overwriting previous properties by setting to
a new collection on publish. Needs to update/append to the property collection.

Allow Projects to be parents, not just Containers.

Fix microsoft#7259
@eerhardt eerhardt marked this pull request as ready for review January 31, 2025 16:30
@eerhardt eerhardt requested a review from mitchdenny as a code owner January 31, 2025 16:30
@eerhardt eerhardt requested a review from JamesNK January 31, 2025 16:30
@eerhardt
Copy link
Copy Markdown
Member Author

I found 3 more places we should set this by default - our azure emulators that need to spin up other containers.

image

@davidfowl
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs Outdated
Comment thread src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs Outdated
@davidfowl davidfowl merged commit e0079f9 into microsoft:main Feb 1, 2025
@davidfowl
Copy link
Copy Markdown
Contributor

I assume executables also work.

@eerhardt eerhardt deleted the NestSidecar branch February 3, 2025 20:34
@eerhardt
Copy link
Copy Markdown
Member Author

eerhardt commented Feb 4, 2025

I assume executables also work.

Yes, they do.

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2025
@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nest sidecar type resources by default in Dashboard

2 participants