Use last-one-wins conventions for ExistingResourceAnnotation#7403
Merged
captainsafia merged 2 commits intomainfrom Feb 4, 2025
Merged
Use last-one-wins conventions for ExistingResourceAnnotation#7403captainsafia merged 2 commits intomainfrom
captainsafia merged 2 commits intomainfrom
Conversation
captainsafia
force-pushed
the
safia/rm-existing-exceptions
branch
from
5de413d to
3c17e17
Compare
Contributor
|
davidfowl
reviewed
Feb 4, 2025
| if (builder.ApplicationBuilder.ExecutionContext.IsPublishMode) | ||
| { | ||
| builder.Resource.Annotations.Add(new ExistingAzureResourceAnnotation(nameParameter.Resource, resourceGroupParameter?.Resource)); | ||
| builder.WithAnnotation(new ExistingAzureResourceAnnotation(nameParameter.Resource, resourceGroupParameter?.Resource)); |
Contributor
There was a problem hiding this comment.
There's a replace overload.
davidfowl
approved these changes
Feb 4, 2025
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #7249.